Skip to content

fix(acp): settle accepted prompts that fail before turn start - #265

Merged
danielkov merged 2 commits into
mainfrom
fix/acp-accepted-prompt-errors
Oct 13, 2026
Merged

danielkov merged 2 commits into
mainfrom
fix/acp-accepted-prompt-errors

Conversation

@danielkov

Copy link
Copy Markdown
Contributor

Summary

Ensure accepted ACP v2 prompts publish a terminal outcome even when publication or execution fails before a logical turn starts. Parent subagent calls can now observe these failures instead of waiting indefinitely for completion.

Technical details

Accepted prompts open an execution-level Running interval before user-message publication or driver execution. Finalization retains cleanup and content-flush ordering before a single Idle terminal, without fabricating a logical TurnStarted or weakening stale-Idle protection.

Failure to publish the initial Running state isolates the session and rejects subsequent prompts before acceptance. Existing queued-input retention after user-message publication failure remains unchanged.

kit-code-agent[bot]
kit-code-agent Bot previously approved these changes Oct 8, 2026

@kit-code-agent kit-code-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found. The changes look good to merge.

@kit-code-agent kit-code-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found. The changes look good to merge.

@danielkov
danielkov merged commit 9efba48 into main Oct 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant